[material-ui][Select] SelectProps fix variant #41359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mаартен - Maarten <maarten@oudenniel.nl>
maapteh
changed the title
Netlify deploy previewhttps://deploy-preview-41359--material-ui.netlify.app/ Bundle size report |
1 task
danilo-leal
added
component: select
|
Hey @maapteh, thanks for working on this! The problem I see is that for the current implementation, the variant is not optional but required. If not provided, it would default to |
|
We could make it optional for I will have to investigate if that's a proper fix. |
|
Will be fixed by #41405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #41356 not sure about other side effects since this was our only case where it didn't build anymore. Also im stumbled why typing errors are not shown in MUI's pipeline...
The fix still makes sure the intention of the previous PR (which introduced the bug) stays working correctly (choosing props that are only optional with the chosen variant).
So when setting a prop not belonging to the variant it shows the error:
And when the prop is an option it allows it correctly:
fixes #39137 (comment)
blamed #39137
What i still can do is to also change
export type SelectPropsback toexport interface SelectPropsbecause in general also this can be breaking ...