Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Improve color contrast throughout #41387

Merged

Conversation

danilo-leal
Copy link
Contributor

Some fine-tune adjustments to the blue and grey palettes to ensure better contrast (passing WCAG) against light backgrounds. Also baked in some minor spacing & typography adjustments. Hopefully, this will get us closer to hitting 100 in the desktop Accessibility score on Lighthouse :)

@danilo-leal danilo-leal added accessibility a11y design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Mar 6, 2024
@danilo-leal danilo-leal requested a review from zanivan March 6, 2024 22:43
@danilo-leal danilo-leal self-assigned this Mar 6, 2024
@mui-bot
Copy link

mui-bot commented Mar 6, 2024

Netlify deploy preview

https://deploy-preview-41387--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c376411

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Just left one comment, other than that, it looks good to me :)

docs/src/components/pricing/PricingTable.tsx Show resolved Hide resolved
@danilo-leal danilo-leal requested a review from zanivan March 7, 2024 12:57
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@danilo-leal danilo-leal merged commit 8b2cd39 into mui:master Mar 8, 2024
22 checks passed
@danilo-leal danilo-leal deleted the docs-infra-color-and-spacing-improvements branch March 8, 2024 13:17
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants