-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Improve color contrast throughout #41387
Merged
danilo-leal
merged 9 commits into
mui:master
from
danilo-leal:docs-infra-color-and-spacing-improvements
Mar 8, 2024
Merged
[docs-infra] Improve color contrast throughout #41387
danilo-leal
merged 9 commits into
mui:master
from
danilo-leal:docs-infra-color-and-spacing-improvements
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
accessibility
a11y
design
This is about UI or UX design, please involve a designer
scope: docs-infra
Specific to the docs-infra product
labels
Mar 6, 2024
Netlify deploy previewhttps://deploy-preview-41387--material-ui.netlify.app/ Bundle size report |
zanivan
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! Just left one comment, other than that, it looks good to me :)
zanivan
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
design
This is about UI or UX design, please involve a designer
scope: docs-infra
Specific to the docs-infra product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fine-tune adjustments to the blue and grey palettes to ensure better contrast (passing WCAG) against light backgrounds. Also baked in some minor spacing & typography adjustments. Hopefully, this will get us closer to hitting 100 in the desktop Accessibility score on Lighthouse :)