Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css][docs] Brand name nonbreaking space #41438

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 10, 2024

Because it's a brand name. It's a follow up on #41317.

For example, Apple cares about this type of details: https://www.apple.com/

SCR-20240310-dgck

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/* labels Mar 10, 2024
@mui-bot
Copy link

mui-bot commented Mar 10, 2024

Netlify deploy preview

https://deploy-preview-41438--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 72660ad

@brijeshb42
Copy link
Contributor

Is this space something you copy and paste from somewhere or is it available through keyboard as well?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 10, 2024

available through keyboard as well

It's option + space on macOS: https://en.wikipedia.org/wiki/Non-breaking_space#Keyboard_entry_methods

@siriwatknp siriwatknp merged commit f3a8c41 into mui:master Mar 11, 2024
22 checks passed
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 11, 2024

@siriwatknp Ah hold on, this wasn't ready to be merged #41176 (docs/writing-rules.zip)

oliviertassinari added a commit that referenced this pull request Mar 11, 2024
@oliviertassinari
Copy link
Member Author

Ok, done in be6c430

@oliviertassinari oliviertassinari deleted the pigment-css-brand-name branch March 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants