Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Improve navbar's items hover state #41535

Merged
merged 9 commits into from
Mar 18, 2024
Merged

[website] Improve navbar's items hover state #41535

merged 9 commits into from
Mar 18, 2024

Conversation

EyaOuenniche
Copy link
Contributor

@EyaOuenniche EyaOuenniche commented Mar 17, 2024 •
edited by danilo-leal
Loading

Closes #41534

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2024
@EyaOuenniche
Merge branch 'master' into feature/navbar-hover-color
e2e9df7 
Signed-off-by: EyaOuenniche <122678675+EyaOuenniche@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2024
@mui-bot
Copy link

mui-bot commented Mar 17, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41535--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6b81685

@danilo-leal danilo-leal changed the title Implement Hover Effect for Navbar Links: Changes Link Color on Hover [website] Improve navbar's items hover state Mar 18, 2024
@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Mar 18, 2024
@zannager zannager requested a review from danilo-leal March 18, 2024 15:42
danilo-leal
danilo-leal approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Added a few changes as I don't think we need the more attention-calling blue here. Thanks for picking this up! :)

@danilo-leal danilo-leal merged commit 014fe9a into mui:master Mar 18, 2024
19 checks passed
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 20, 2024
Open
This was referenced Jun 5, 2024
Open
Open
@FaroukAmr FaroukAmr mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 6, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[website] Enhance navbar items hover state
3 participants
@EyaOuenniche @mui-bot @danilo-leal