[docs-infra] Make the Algolia search input label invisible #41542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
accessibility
Netlify deploy previewhttps://deploy-preview-41542--material-ui.netlify.app/ Bundle size report |
bharatkashyap
approved these changes
Mar 18, 2024
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this label existed in the Algolia search input before or I just recently noticed it was visible, even though its class name is
DocSearch-VisuallyHiddenForAccessibility. I guess we indeed don't want that to be visible as it overlaps with the input's placeholder, but it should still be there for accessibility. So, in this PR, I'm just using the available class to add CSS that will visually hide it, as the class name suggests it should be :)