-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Add missing backticks to HTML tag in the installation page #41972
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Appreciate it!
Can I ask for you to point this PR to the next
branch instead, though? You might need to rebase it so you maintain in the PR only the changed file.
Backticks were added around the <head /> HTML tag to render it as code. Without it the tag just does not render. Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com>
I'm not sure if I did this correctly. I basically rebased locally, forced pushed the branch to my fork and then changed from master to next in the PR. If this doesn't work, no big deal. I'll try again some other day by making the change in the next branch. |
…tion page (#41972) Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
…tion page (mui#41972) Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Backticks were added around the HTML tag to render it as code.
Without it the tag just does not render.