-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Migrate components to support CSS extraction #42001
Merged
Merged
Changes from 57 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
b2507ee
migrate Icon
siriwatknp 43803b1
migrate Dialog
siriwatknp 317d955
migrate DialogActions
siriwatknp e59eee1
fix MemberExpression case
siriwatknp fc9c76d
migrate DialogContent
siriwatknp 956f331
migrate DialogContentText
siriwatknp 76a6ecb
migrate Drawer
siriwatknp 83d8839
migrate Input
siriwatknp 9206dd0
migrate InputAdornment
siriwatknp da3fef1
migrate InputBase
siriwatknp 5f3d249
migrate OutlinedInput
siriwatknp 2fce0ca
migrate TablePagination
siriwatknp 41e9737
migrate InputLabel
siriwatknp eb821da
migrate Menu
siriwatknp c02207e
migrate Paper
siriwatknp ee3f1b6
migrate Skeleton
siriwatknp 6d7989f
migrate Snackbar
siriwatknp f1eb8bf
migrate SpeedDial
siriwatknp 988a6bf
migrate Tabs
siriwatknp a50ba76
migrate Tooltip
siriwatknp a6133d5
run docs:api
siriwatknp 1c56fe5
fix lint
siriwatknp 984e7ca
fix snackbar
siriwatknp 6c17d04
remove xs
siriwatknp d9a858f
shorten icon
siriwatknp 7c0fa9d
fix comment
siriwatknp 6c2ea6f
fix Icon metadata
siriwatknp 68c95ea
add explicit disableRipple
siriwatknp 089feb5
migrate SwitchBase
siriwatknp 942490b
add demo pages
siriwatknp c554e62
Merge branch 'next' of https://github.com/mui/material-ui into mui/cs…
siriwatknp 3392cbe
migrate FilledInput
siriwatknp 8685c92
use direct module
siriwatknp 1a10ef5
migrate the rest
siriwatknp 920a703
migrate Collapse
siriwatknp 7e6e5fa
migrate BreadcrumbCollapsed
siriwatknp 3727c6f
migrate the rest
siriwatknp 6e2269d
fixes
siriwatknp 023c2a8
remove unparsable sx demo
siriwatknp 2b91598
add component check
siriwatknp 7832e33
remove unparsable sx demos
siriwatknp 91034bf
update pigment to latest
siriwatknp ea0a80d
pnpm dedupe
siriwatknp 9e78be7
Merge branch 'next' of https://github.com/mui/material-ui into mui/cs…
siriwatknp 33445aa
update lock file
siriwatknp 6be45c1
fix FormLabel
siriwatknp fb84a93
Merge branch 'next' of https://github.com/mui/material-ui into mui/cs…
siriwatknp c62d85a
revert demo pages
siriwatknp 002bf22
test ci without macos
siriwatknp f9e5c59
remove unnecessary change
siriwatknp e59210f
fix FormLabel
siriwatknp 0cb1f75
Fix NativeSelectInput
siriwatknp f76758f
revert ci change
siriwatknp 0eefa24
set mem to 4GB
siriwatknp 2ea2584
migrate Typography
siriwatknp 444a60f
migrate Link
siriwatknp d07e032
add workaround for toString error
siriwatknp 15c782e
migrate LoadingButton
siriwatknp e7b3f84
fix test
siriwatknp 1ea30b0
bring back sx insertion
siriwatknp 11f5c47
run proptypes
siriwatknp 6d0c54d
fix lint
siriwatknp 279e4cc
Merge branch 'next' of https://github.com/mui/material-ui into mui/cs…
siriwatknp fb57ad7
move other.style to last
siriwatknp 1276d4e
update comment as suggeste
siriwatknp cb85122
Merge branch 'next' of https://github.com/mui/material-ui into mui/cs…
siriwatknp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,6 +117,7 @@ const Checkbox = React.forwardRef(function Checkbox(inProps, ref) { | |
indeterminateIcon: indeterminateIconProp = defaultIndeterminateIcon, | ||
inputProps, | ||
size = 'medium', | ||
disableRipple = false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's with this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Otherwise, variants: [
{ props: { color: 'default', disableRipple: false } }, style: { … } },
] |
||
className, | ||
...other | ||
} = props; | ||
|
@@ -126,6 +127,7 @@ const Checkbox = React.forwardRef(function Checkbox(inProps, ref) { | |
|
||
const ownerState = { | ||
...props, | ||
disableRipple, | ||
color, | ||
indeterminate, | ||
size, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A workaround for mui/pigment-css#10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this here fixes the issue? Should this then be made part of the library itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can confirm that this prevents the error. I added here just to be a workaround but if you think it should be a part of Pigment, I am happy to add it. However, I think it should be a separate package for integrating with MUI system, not a part of nextjs/vite plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this would be required for every project that uses Material UI and Pigment CSS, we should make it part of the library. Do we know why it is required tough? Maybe we are fixing a symptom, not the problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably related issue: mui/pigment-css#8