Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix release:publish:dry-run script #42018

Closed
wants to merge 1 commit into from
Closed

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Apr 24, 2024

The --registry argument was available when lerna was used. pnpm does not support it, but it does have the same --[dry-run attribute](https://pnpm.io/cli/publish#--dry-run) as npm.

I noticed this when working on mui/mui-x#11875.

Signed-off-by: Lukas <llukas.tyla@gmail.com>
@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Apr 24, 2024
@LukasTy LukasTy requested a review from a team April 24, 2024 14:04
@LukasTy LukasTy self-assigned this Apr 24, 2024
@michaldudak
Copy link
Member

I used it without issues. But it's fair to say that it wasn't really a dry run but publishing to a local registry. The pnpm's dry-run works differently - it just doesn't publish.

@LukasTy
Copy link
Member Author

LukasTy commented Apr 24, 2024

@michaldudak Thank you for confirming it. 👍
Double-checked that it works.
The suggested port is used by default by verdaccio.

@LukasTy LukasTy closed this Apr 24, 2024
@LukasTy LukasTy deleted the LukasTy-patch-1 branch April 24, 2024 14:30
@LukasTy LukasTy removed the request for review from a team April 24, 2024 14:31
@LukasTy LukasTy removed their assignment Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants