-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Fix slider in color customization playground twitches when sliding #42119
Conversation
Netlify deploy previewhttps://deploy-preview-42119--material-ui.netlify.app/ Bundle size report |
@mj12albert can you please look at the changes whenever you get a chance. |
@Nashyn Thanks for working on this! I will review this today |
@Nashyn Your changes does indeed fix the issue 👍 Just wondering how you found the fix and if you have tried other alternatives - it would be preferable if this could be fixed without using magic numbers ~ |
@mj12albert I found the fix while inspecting and trying roundabouts with slider css and saw a twitch was occuring due to conflicting styles. I have committed the changes you asked for if the solution works without magic number. Can you please review it. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nashyn Thanks for the pull request.
There were conflicting css issues that was preventing the slider from working smooth
Could you explain what were the conflicting CSS styles, and how does wrapping Typography in a div
resolve the issue?
Since this PR is inactive, I am closing it. |
Fixes #42019
There were conflicting css issues that was preventing the slider from working smoothly when going from left to right or right to left and causing twitch after 100 and 50.
The issue is now solved as shown in the video below:
Twitch_issue_fixed.mp4