Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix sentence in the All components page #42336

Merged
merged 3 commits into from
May 31, 2024
Merged

[material-ui][docs] Fix sentence in the All components page #42336

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ad78e9
missing what "the latest" referred to
danilo-leal May 22, 2024
4d3b222
Sam's review
danilo-leal May 29, 2024
a0f44f8
Merge branch 'next' into fix-sentence-all-components-page
danilo-leal May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/material/all-components/all-components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Material UI aims to provide building blocks for developers to create great user interfaces using the Material Design guidelines as a reference, which we strive to follow where practical.
That doesn't mean we support every component or every feature.
We often apply common sense and the latest around web development wherever their guidelines are missing or contradictory.
We often apply common sense and the latest knowledge around web development wherever their guidelines are missing or contradictory.

Check warning on line 7 in docs/data/material/all-components/all-components.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'We'.

Raw Output:
{"message": "[Google.We] Try to avoid using first-person plural like 'We'.", "location": {"path": "docs/data/material/all-components/all-components.md", "range": {"start": {"line": 7, "column": 1}}}, "severity": "WARNING"}
danilo-leal marked this conversation as resolved.
Show resolved Hide resolved

## Inputs

Expand Down
Loading