-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui][Text Field] Keep the text caret position when clicking the visibility adornment #42595
[docs][material-ui][Text Field] Keep the text caret position when clicking the visibility adornment #42595
Conversation
Netlify deploy previewhttps://deploy-preview-42595--material-ui.netlify.app/ Bundle size report |
Thanks for working on this @appleSimple! I think the change makes sense. What do you think about this behaviour @zanivan? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch—it makes a lot of sense! As I see, the common behavior is to fill in the password field, click the button to check if it's spelled correctly, or see what you've already inputted. IMO, positioning the caret this way aligns better with that behavior.
Could this be a breaking change? Developers might have already implemented local workarounds for this.
This is only a change in the docs so it won't cause any breaking changes 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@appleSimple may I ask you to run pnpm docs:typescript:formatted
and commit the changes so the CI succeeds?
Thank you for approvals guys! @zanivan @DiegoAndai . I ran But confilcted file was happened, What can I do? |
Hey @appleSimple, I recommend you do the following:
Let me know if that works. |
This reverts commit c82f77f.
oh, @DiegoAndai Thank you very much!! Finally I'm done, please check it. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @appleSimple!
… caret position change to very front. (mui#42595)
when click password visibility button, text caret position change to very front.
Suggestion
I referred to Ant Design source, and they modified same issue before. (code here)
before
password-bug.mov
after
password-fix.mov
thanks for read!