Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update CSS theme variables related content #43130

Merged
merged 99 commits into from
Aug 20, 2024
Merged

[docs] Update CSS theme variables related content #43130

merged 99 commits into from
Aug 20, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jul 31, 2024 •
edited
Loading

@siriwatknp
wip
037f62b
@siriwatknp
Merge branch 'next' of https://github.com/mui/material-ui into remove…
e2fae64 
…-css-vars-provider
@siriwatknp
rename type
2258db1
@siriwatknp
only call extendTheme when CssVarsProvider is used
e22d068
@siriwatknp
create new ThemeProvider and createTheme
5ba82d5
@siriwatknp
finish first step
3106aa9
@siriwatknp
move some props to ThemeProviderCssVariablesProps
ab0424a
@siriwatknp
remove old createTheme and extendTheme
e7bf7dc
@siriwatknp
fix import paths
36ec12e
@siriwatknp
fix all tests
2603b25
@siriwatknp
Merge branch 'next' of https://github.com/mui/material-ui into remove…
71d750a 
…-css-vars-provider
@siriwatknp
switch to new ThemeProvider
4e0f400
@siriwatknp
fix export path
82aa32e
@siriwatknp
switch to enable method
584056e
@siriwatknp
fix types
de9fb70
@siriwatknp
Merge branch 'next' of https://github.com/mui/material-ui into remove…
15440a5 
…-css-vars-provider
@siriwatknp
fix rsc
d1b7783
@siriwatknp
fix test
bfac926
@siriwatknp
widen the type
20d1da5
@siriwatknp
Revert "fix all tests"
e076c5c 
This reverts commit 2603b25.
@siriwatknp
fix disableTransitionOnChange test
28873d0
@siriwatknp
fix getInitialTheme
fd557f5
@siriwatknp
add test
7337a7d
@siriwatknp
fix types
7d8f690
@siriwatknp
flatten nested folder
0bc2274
@siriwatknp
fix types
d239b2f
@siriwatknp
fix lint
cc97041
@siriwatknp
Merge branch 'next' of https://github.com/mui/material-ui into remove…
015b68e 
…-css-vars-provider
@siriwatknp
fix alpha usage
24f9a88
@siriwatknp
fix naming
4e36f1e
DiegoAndai
DiegoAndai reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final suggestion @siriwatknp

Thanks for implementing the previous suggestions 😊

docs/data/material/migration/migrating-to-v6/migrating-to-v6.md Outdated Show resolved Hide resolved
@DiegoAndai
Copy link
Member

The content here is RTM from my perspective.

Important note: Please wait until #43073 is merged to merge this one, as the upgrade guide URL changes in that PR (migrating-to-v6 -> upgrade-to-v6). After that PR is merged, we have to modify the links in this PR as well.

@DiegoAndai DiegoAndai requested review from alelthomas and removed request for samuelsycamore August 14, 2024 22:45
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 18, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 19, 2024
DiegoAndai
DiegoAndai approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTM 😊

samuelsycamore
samuelsycamore reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small copyedits here, otherwise I think this is just about ready to go!

docs/data/material/customization/css-theme-variables/usage.md Outdated Show resolved Hide resolved
docs/data/material/customization/css-theme-variables/usage.md Outdated Show resolved Hide resolved
docs/data/material/customization/dark-mode/dark-mode.md Outdated Show resolved Hide resolved
docs/data/material/customization/dark-mode/dark-mode.md Outdated Show resolved Hide resolved
docs/data/material/customization/dark-mode/dark-mode.md Outdated Show resolved Hide resolved
docs/data/material/customization/palette/palette.md Outdated Show resolved Hide resolved
docs/data/material/customization/theming/theming.md Outdated Show resolved Hide resolved
@siriwatknp @samuelsycamore
Apply suggestions from code review
f08a601 
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@siriwatknp siriwatknp enabled auto-merge (squash) August 20, 2024 02:31
@siriwatknp
Update docs/data/material/customization/theming/theming.md
185c758 
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@siriwatknp siriwatknp merged commit 3208bfe into mui:next Aug 20, 2024
22 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@shagg0r shagg0r mentioned this pull request Sep 18, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 18, 2024
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore left review comments

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@alelthomas alelthomas Awaiting requested review from alelthomas

Assignees

@siriwatknp siriwatknp

Labels
docs Improvements or additions to the documentation v6.x
Projects
Material UI
Status: Done
Milestone
Material UI: v6
Development

Successfully merging this pull request may close these issues.
7 participants
@siriwatknp @mui-bot @DiegoAndai @flaviendelangle @mnajdova @samuelsycamore @zannager