-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Change React.ReactElement<any,any> type from any to unknown #43358
Conversation
Netlify deploy previewhttps://deploy-preview-43358--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this @sai6855!
I could find other instances of ReactElement<any>
still present. No need to cover them in this PR, but
- If we don't cover all cases, we should remove the "close" keyword in the description.
- If you wish to close the issue in this PR, then we should cover all cases. If you do, then skip the
base/
andjoy/
.
Whatever option you prefer, let me know 😊
Ah okay, I've changed |
@DiegoAndai opened follow up PR for some of left over instances #43402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sai6855 😊
Part of: #42380
since no one has taken up the issue since last 3 months, i opened PR fixed it