[material-ui] Do not generate CSS variables for a custom spacing function #43389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43378
Before: I was too optimistic that the custom spacing function from users will result will used with just number or string (see the test cases), so when creating a theme with
cssVariables: true
, it tries to create a spacing variable and use multiply with the user's input like thiscalc(var(--mui-spacing) * 2)
.However, this is a breaking change for a case like #43378 if the user provide a custom value when using
theme.spacing('xs')
.After: If the custom spacing is a function, do not create a spacing variable and do not alter the function.