Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add two Toolpad Core components to Material UI sidebar #43391

Merged
merged 3 commits into from
Aug 26, 2024
Merged

[docs] Add two Toolpad Core components to Material UI sidebar #43391

merged 3 commits into from
Aug 26, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Aug 21, 2024 •
edited
Loading

Screenshot 2024-08-22 at 7 37 43 PM

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Aug 21, 2024
@mui-bot
Copy link

mui-bot commented Aug 21, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43391--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9dccc49

@prakhargupta1
Copy link
Member Author

IDK how to make this test pass. I tried pnpm docs:i18n in the CLI but it didn't work.

@Janpot
Copy link
Member

Janpot commented Aug 21, 2024

IDK how to make this test pass. I tried pnpm docs:i18n in the CLI but it didn't work.

The X ones are excluded here in the '/x/reacy-' entry. We could add one for Toolpad as well

material-ui/docs/scripts/i18n.ts

Line 11 in 6bb06b9

const EXCLUDES = ['/api', '/blog', '/x/react-'];

@prakhargupta1 prakhargupta1 requested a review from a team August 22, 2024 06:42
@bharatkashyap bharatkashyap mentioned this pull request Aug 22, 2024
Merged
@prakhargupta1 prakhargupta1 merged commit ea34b29 into mui:next Aug 26, 2024
22 checks passed
@prakhargupta1 prakhargupta1 deleted the add-toolpad-to-core-sidebar branch August 26, 2024 07:24
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@shagg0r shagg0r mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Merged
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 21, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

@Janpot Janpot Awaiting requested review from Janpot

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prakhargupta1 @mui-bot @Janpot @alexfauquette @samuelsycamore