-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Refine templates theme selector #43396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Hey @aarongarciah, could you give me a hand with the double scrollbar in the templates? After adding the |
@zanivan sure, let me take a look |
@zanivan this scrollable container highlighted in the screenshot is the responsible: It should use I think we could make it work without calculations, too. Let me take a deeper look. But for now, that should fix it. |
@zanivan here's an example approach of how we could treat the navbar as a "frame" so we don't need to make calculations for scrollable containers: Not to be applied in this PR (unless you want to), just wanted to let you know another approach. There's a small issue on small viewports where the scroll bar is partially hidden behind the header. We can fix it in another PR. |
@aarongarciah Thanks so much! Will merge this one and open a new just to fix the frames 👍 |
<FormControl variant="outlined" sx={{ minWidth: 180 }}> | ||
<Select | ||
size="small" | ||
labelId="theme-select-label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback—it should be fixed in #43604
Description
Fixes item 10 from #41469
Fixes item 1 from #42609
Refined the theme and mode selector by moving them from within the template to a top bar that also includes a back button. This change cleans up the template layout and enhances the visibility of the theme selector and mode toggler.
Preview
All templates from https://deploy-preview-43396--material-ui.netlify.app/material-ui/getting-started/templates/