[button] Add missing customize points for span #43436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43436--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
force-pushed
the
loading-button-fix-loader
branch
from
2092c99
to
6b6a620
Compare
Comment on lines
+204
to
+205
| }, | ||
| })({ |
There was a problem hiding this comment.
Ah, I guess I forgot #43372
There was a problem hiding this comment.
We are not using it if there it is not a callback, but it is missing in the other slots, I am adding it.
There was a problem hiding this comment.
Ah right, ok, it's the opposite, makes sense.
mnajdova
approved these changes
Aug 26, 2024
Comment on lines
+204
to
+205
| }, | ||
| })({ |
There was a problem hiding this comment.
Ah right, ok, it's the opposite, makes sense.
| import { | ||
| capitalize, | ||
| unstable_useId as useId, | ||
| unstable_memoTheme as memoTheme, |
There was a problem hiding this comment.
I'm confused by this, issue created #43440
|
Confirmed this change solved the regression: https://github.com/mui/mui-private/pull/560. |
This was referenced Sep 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to fix the regression introduced by #35198 that we noticed on the store:
Origin: https://github.com/mui/mui-private/pull/511. Reproduction: https://codesandbox.io/p/sandbox/affectionate-night-64fljj?workspaceId=836800c1-9711-491c-a89b-3ac24cbd8cd8
I have tried in #43400 to remove the
<span>, but it didn't work in production. Instead, we can use what Material UI v4 was using to make the span more transparent:material-ui/packages/material-ui/src/Button/Button.js
Line 37 in cd0884f
Also, to note that this span should have had the API to customize it, I'm adding this at the same time.