-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update Premium price and remove any mention to cap #43466
[website] Update Premium price and remove any mention to cap #43466
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is more to do. The plan comparison is not correct https://deploy-preview-43466--material-ui.netlify.app/pricing//
- Charts: some of the features are flagged as pending, but they are available.
- Tree View: it makes it feel that everything is open source, but no. It needs its own detail view.
Done, @oliviertassinari! I missed these points, but it's indeed a good opportunity to update them. |
cce03c5
to
99e7289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR would close #42328. There are stuff we could copy from there. Maybe adding "Selection" could make sense.
'charts/heatmap': <ColumnHead label="Heatmap" href="/x/react-charts/heatmap/" />, | ||
'charts/treemap': <ColumnHead label="Treemap" href="/x/react-charts/treemap/" />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciated that in the previous positions, it was easily to compare plans, taking along term view. I could see use reverting. Or at least once every feature is built, we should revert.
<ColumnHead label="Inline editing" href="/x/react-tree-view/rich-tree-view/editing/" /> | ||
), | ||
'tree-view/drag-to-reorder': ( | ||
<ColumnHead label="Drag to reorder" href="/x/react-tree-view/rich-tree-view/ordering/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe simply to march the page it links to title.
<ColumnHead label="Drag to reorder" href="/x/react-tree-view/rich-tree-view/ordering/" /> | |
<ColumnHead label="Ordering" href="/x/react-tree-view/rich-tree-view/ordering/" /> |
A saw this too for the data grid column ordering feature: #42328 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must we match the page title, though?
Because I think that just "Ordering" without more context doesn't communicate well what the feature is about, so we're basically forcing users to leave the pricing page, whereas "drag to reorder" feels something that you can understand a bit better from the label itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Ordering" without more context doesn't communicate well what the feature is about, so we're basically forcing users to leave the pricing page, whereas "drag to reorder" feels something that you can understand a bit better from the label itself.
If it's true, with the pricing page, is it different with:
or?
I'll merge this PR now so we can update the pricing page. We can refine the comparison on pricing table on a followup without blocking this. (Please feel free to leave any comments, @flaviendelangle ) |
@joserodolfofreitas It looks nice 👍 |
Summary
Preview
https://deploy-preview-43466--material-ui.netlify.app/pricing/
A continuation of #41962 and #42328