Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system][InitColorSchemeScript] Use let/const instead of var #43468

Merged
merged 6 commits into from
Aug 30, 2024
Merged

[system][InitColorSchemeScript] Use let/const instead of var #43468

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94bbed9
fix: variables
ishon19 Aug 26, 2024
f0f0039
Merge branch 'master' of github.com:mui/material-ui into 43418-use-le…
ishon19 Aug 26, 2024
2226b84
Apply suggestions from code review
siriwatknp Aug 28, 2024
cb147fb
fix: `mql` and `mode` to const
ishon19 Aug 28, 2024
cecd242
Merge branch '43418-use-let-instead-of-var' of shreyans:ishon19/mater…
ishon19 Aug 28, 2024
149e31b
Merge branch 'master' into 43418-use-let-instead-of-var
ZeeshanTamboli Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/mui-system/src/InitColorSchemeScript/InitColorSchemeScript.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ export default function InitColorSchemeScript(options?: InitColorSchemeScriptPro
dangerouslySetInnerHTML={{
__html: `(function() {
try {
var mode = localStorage.getItem('${modeStorageKey}') || 'system';
var colorScheme = '';
var dark = localStorage.getItem('${colorSchemeStorageKey}-dark') || '${defaultDarkColorScheme}';
var light = localStorage.getItem('${colorSchemeStorageKey}-light') || '${defaultLightColorScheme}';
let mode = localStorage.getItem('${modeStorageKey}') || 'system';
let colorScheme = '';
const dark = localStorage.getItem('${colorSchemeStorageKey}-dark') || '${defaultDarkColorScheme}';
const light = localStorage.getItem('${colorSchemeStorageKey}-light') || '${defaultLightColorScheme}';
siriwatknp marked this conversation as resolved.
Show resolved Hide resolved
if (mode === 'system') {
// handle system mode
var mql = window.matchMedia('(prefers-color-scheme: dark)');
ZeeshanTamboli marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading