Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Skip shadow DOM regression test #43500

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[docs-infra] Skip shadow DOM regression test #43500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32553f9
Add mechanism to skip regression tests for certain demos
aarongarciah Aug 28, 2024
7429043
Modify condition to exclude regression tests
aarongarciah Aug 28, 2024
76a7d04
Simplify
aarongarciah Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...customization/shadow-dom/ShadowDOMDemo.js → ...ization/shadow-dom/ShadowDOMDemoNoSnap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';

export default function ShadowDOMDemo() {
export default function ShadowDOMDemoNoSnap() {
return (
<iframe
title="codesandbox"
Expand Down
2 changes: 1 addition & 1 deletion docs/data/material/customization/shadow-dom/shadow-dom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ const theme = createTheme({

In the example below you can see that the component outside of the shadow DOM is affected by global styles, while the component inside of the shadow DOM is not:

{{"demo": "ShadowDOMDemo.js", "hideToolbar": true, "bg": true}}
{{"demo": "ShadowDOMDemoNoSnap.js", "hideToolbar": true, "bg": true}}
4 changes: 3 additions & 1 deletion test/regressions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ importRegressionFixtures.keys().forEach((path) => {
}, []);

const blacklist = [
// Excludes demos that we don't want
/^docs-(.*)(?<=NoSnap)\.png$/,
// Blog template components and theme customizations
'docs-getting-started-templates-blog/Blog.png',
'docs-getting-started-templates-blog/TemplateFrame.png',
Expand Down Expand Up @@ -254,7 +256,7 @@ function excludeDemoFixture(suite, name) {
}

// assume regex
if (pattern.test(suite)) {
if (pattern.test(`${suite}/${name}.png`)) {
unusedBlacklistPatterns.delete(pattern);
return true;
}
Expand Down