-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][figma] Clarity state or Figma Plugin component export #43543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw a couple of comments about this in https://www.figma.com/community/plugin/1336346114713490235/material-ui-sync. Right now, this feature is trending toward being removed, so we shouldn't promise more coverage. A general thought, anytime we no a major, we should try to remove stuff aggressively: Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
added
docs
Improvements or additions to the documentation
design: material
This is about Material Design, please involve a visual or UX designer in the process
labels
Aug 31, 2024
Netlify deploy previewBundle size report |
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Outdated
Show resolved
Hide resolved
…ui-sync.md Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Outdated
Show resolved
Hide resolved
…ui-sync.md Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Outdated
Show resolved
Hide resolved
…ui-sync.md Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
zanivan
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense! I just have a couple of remarks, but nothing that should block the PR :)
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Outdated
Show resolved
Hide resolved
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Show resolved
Hide resolved
…ui-sync.md Co-authored-by: Victor Zanivan Monteiro <victorzanivan@gmail.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design: material
This is about Material Design, please involve a visual or UX designer in the process
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a couple of comments about this in https://www.figma.com/community/plugin/1336346114713490235/material-ui-sync, e.g. mui/mui-design-kits#389 asking about
A general thought, anytime we no a major, we should try to remove stuff aggressively: https://youtu.be/tRsxLLghL1k?si=sRhbVRHVLRR83pMX&t=574. This feature might be je trending toward being removed.
Before: https://mui.com/material-ui/design-resources/material-ui-sync/#customizing-components
After: https://deploy-preview-43543--material-ui.netlify.app/material-ui/design-resources/material-ui-sync/#customizing-components