Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][modal] Fix comment location #44026

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 6, 2024

I was reading the source and saw this strange comment. It looks like this was lost during a code refactoring.

@oliviertassinari oliviertassinari added the component: modal This is the name of the generic UI component, not the React module! label Oct 6, 2024
@mui-bot
Copy link

mui-bot commented Oct 6, 2024

Netlify deploy preview

https://deploy-preview-44026--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fa09a2c

@mnajdova mnajdova merged commit e5b81c8 into mui:master Oct 6, 2024
23 checks passed
@oliviertassinari oliviertassinari deleted the comment-clean-up branch October 6, 2024 21:20
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 6, 2024
@oliviertassinari oliviertassinari changed the title [modal] Fix comment location [core][modal] Fix comment location Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: modal This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants