Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Align next dependency specifier across project #44036

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 7, 2024

Noticed this morning that we had two Next.js versions in node_module (has been fixed by renovatebot now). This was caused by having all but one specifier marked with ^ and a lockfile maintenance cycle updating all but this one.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Oct 7, 2024
@mui-bot
Copy link

mui-bot commented Oct 7, 2024

Netlify deploy preview

https://deploy-preview-44036--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8cc5feb

@Janpot Janpot marked this pull request as ready for review October 7, 2024 16:30
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Janpot Janpot merged commit 48c6682 into mui:master Oct 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants