Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Sync career FAQ with Notion #44678

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

@mui-bot
Copy link

mui-bot commented Dec 7, 2024

Netlify deploy preview

https://deploy-preview-44678--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d7aaaed

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Dec 7, 2024
@@ -78,7 +78,6 @@ export default function OurValues() {
height: '100%',
display: 'flex',
flexDirection: 'column',
alignItems: 'space-between',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dead code, doesn't exist.

<AccordionSummary
expandIcon={<KeyboardArrowDownRounded sx={{ fontSize: 20, color: 'primary.main' }} />}
>
<Typography variant="body2" component="h3" sx={{ fontWeight: 'bold' }}>
<Typography variant="body2" component="span" sx={{ fontWeight: 'bold' }}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h3 > h3 what was that 😄

<Box sx={{ m: alwaysCenter ? 'auto' : 'none' }}>
<Box sx={{ m: alwaysCenter ? 'auto' : null }}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dead code, doesn't exist.

toc?: TableOfContentsEntry[];
userLanguage?: string;
ignoreLanguagePages?: (path: string) => boolean;
options: object;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was forgotten

Copy link

@nadjakovacev nadjakovacev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@oliviertassinari oliviertassinari merged commit 04ac13a into mui:master Dec 23, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the sync-careers-page branch December 23, 2024 22:41
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants