-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Sync career FAQ with Notion #44678
[website] Sync career FAQ with Notion #44678
Conversation
Netlify deploy previewhttps://deploy-preview-44678--material-ui.netlify.app/ Bundle size report |
@@ -78,7 +78,6 @@ export default function OurValues() { | |||
height: '100%', | |||
display: 'flex', | |||
flexDirection: 'column', | |||
alignItems: 'space-between', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dead code, doesn't exist.
<AccordionSummary | ||
expandIcon={<KeyboardArrowDownRounded sx={{ fontSize: 20, color: 'primary.main' }} />} | ||
> | ||
<Typography variant="body2" component="h3" sx={{ fontWeight: 'bold' }}> | ||
<Typography variant="body2" component="span" sx={{ fontWeight: 'bold' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h3 > h3 what was that 😄
<Box sx={{ m: alwaysCenter ? 'auto' : 'none' }}> | ||
<Box sx={{ m: alwaysCenter ? 'auto' : null }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dead code, doesn't exist.
toc?: TableOfContentsEntry[]; | ||
userLanguage?: string; | ||
ignoreLanguagePages?: (path: string) => boolean; | ||
options: object; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was forgotten
b6a1f24
to
d7aaaed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Making a small step toward fixing https://www.notion.so/mui-org/people-Sync-hiring-FAQ-content-12bfa7c6cb42439296d0425e743c9f4b.
I saw this from the question asked in https://app.ashbyhq.com/home/upcoming/right-side/candidates/46022b97-5efc-4584-bb81-61cea92578e4/applications/0179f09d-0ee7-4ffb-acb4-d201a854cce5.
Preview: https://deploy-preview-44678--material-ui.netlify.app/careers/#faq