Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Rescue missing backports v5 #44712

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 10, 2024

Some React 19 JSX backports were missed when we removed the mui-base dependency. For some reason, even though the original PR has React.JSX.Element (example), the backport had JSX.Element (example).

@mui-bot
Copy link

mui-bot commented Dec 10, 2024

Netlify deploy preview

https://deploy-preview-44712--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a026201

@DiegoAndai DiegoAndai self-assigned this Dec 10, 2024
@DiegoAndai DiegoAndai added core Infrastructure work going on behind the scenes v5.x and removed core Infrastructure work going on behind the scenes labels Dec 10, 2024
@DiegoAndai DiegoAndai force-pushed the rescue-missing-backports-v5 branch from 5145146 to a026201 Compare December 10, 2024 12:12
@DiegoAndai DiegoAndai changed the title [core] Rescue missing backports v5 [typescript] Rescue missing backports v5 Dec 10, 2024
@DiegoAndai DiegoAndai marked this pull request as ready for review December 10, 2024 12:29
@DiegoAndai DiegoAndai merged commit f4f1013 into mui:v5.x Dec 10, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the rescue-missing-backports-v5 branch December 10, 2024 13:23
@DiegoAndai DiegoAndai mentioned this pull request Dec 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants