[material-ui][TableSortLabel] Add slots and slotProps #44728
Conversation
Netlify deploy previewhttps://deploy-preview-44728--material-ui.netlify.app/ TableSortLabel: parsed: +2.13% , gzip: +1.89% Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: table
|
Based on the decision, we are move forward as planned before by supporting callback in the slotProps. |
|
@siriwatknp Added |
| */ | ||
| icon: SlotProps< | ||
| React.ElementType<React.SVGAttributes<SVGSVGElement>>, | ||
| {}, |
There was a problem hiding this comment.
| {}, | |
| TableSortLabelIconSlotPropsOverrides, |
| */ | ||
| root: SlotProps< | ||
| React.ElementType<React.HTMLAttributes<HTMLSpanElement>>, | ||
| {}, |
There was a problem hiding this comment.
| {}, | |
| TableSortLabelRootSlotPropsOverrides, |
| /** | ||
| * Props forwarded to the icon slot. | ||
| */ | ||
| icon: SlotProps< |
There was a problem hiding this comment.
nit: can you move the root first (before icon). I find it easier to scan.
| } | ||
| >; | ||
|
|
||
| export interface TableSortLabelOwnerState extends TableSortLabelProps {} |
There was a problem hiding this comment.
| export interface TableSortLabelOwnerState extends TableSortLabelProps {} | |
| export interface TableSortLabelOwnerState extends TableSortLabelOwnProps {} |
To prevent recursion types.
|
|
||
| export interface TableSortLabelOwnerState extends TableSortLabelProps {} | ||
|
|
||
| export interface TableSortLabelOwnProps extends TableSortLabelSlotsAndSlotProps { |
There was a problem hiding this comment.
Moved TableSortLabelSlotsAndSlotProps to TableSortLabelTypeMap instead
| export interface TableSortLabelOwnProps extends TableSortLabelSlotsAndSlotProps { | |
| export interface TableSortLabelOwnProps { |
export type TableSortLabelTypeMap<
AdditionalProps = {},
RootComponent extends React.ElementType = 'span',
> = ExtendButtonBaseTypeMap<{
- props: AdditionalProps & TableSortLabelOwnProps;
+ props: AdditionalProps & TableSortLabelOwnProps & TableSortLabelSlotsAndSlotProps;
defaultComponent: RootComponent;
}>;
Part of #41281
This PR just adds
slotsandslotPropsand doesn't deprecateIconComponentyet. Check this comment for why #42157 (comment)