-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Change icon source URL and add overrides #45020
Open
siriwatknp
wants to merge
8
commits into
mui:master
Choose a base branch
from
siriwatknp:icons/add-outline-round
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45020--material-ui.netlify.app/ Bundle size report |
siriwatknp
changed the title
[icons] Remove blacklist icons and rerun the script
[icons] Change icon source and add overrides
Jan 14, 2025
siriwatknp
changed the title
[icons] Change icon source and add overrides
[icons] Change icon source url and add overrides
Jan 14, 2025
siriwatknp
changed the title
[icons] Change icon source url and add overrides
[icons] Change icon source URL and add overrides
Jan 14, 2025
Can you check also #44970? |
I checked both Material Icons and Symbol, no reference that I can use as an override. I think this should be fixed from Material icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added files caused by updating the icons source url to be the latest one (based on Material icons site).
AreaChart
from the ignored listSee the fix
See the fix
[See the fix](import InfoOutlineRoundedIcon from '@mui/icons-material/InfoOutlineRounded';)
See the fix
See the fix