Skip to content

[code-infra] Remove modern bundles #45808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025
Merged

[code-infra] Remove modern bundles #45808

merged 7 commits into from
Apr 8, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 3, 2025

Closes #45780
Fixes mui/mui-public#302

To Do:

  • upgrade migration guide

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Apr 3, 2025
@mui-bot
Copy link

mui-bot commented Apr 3, 2025

@Janpot Janpot marked this pull request as ready for review April 4, 2025 12:56
@zannager zannager requested a review from mapache-salvaje April 7, 2025 13:15
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor copy edits otherwise LGTM!

Janpot and others added 4 commits April 7, 2025 19:05
Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot requested a review from a team April 8, 2025 08:17
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this breaking? Seems odd that we are adding it now 🤔

@Janpot
Copy link
Member Author

Janpot commented Apr 8, 2025

Isn't this breaking?

Our current recommendations aren't working. And even if they were working it would be non-breaking as well, as it would just fall back gracefully to the esm bundle. It seems more appropriate to just remove it as the modern bundles don't really contain a significant improvement to bundle size. But yes, ideally, we should've just done this as part of v7.

@LukasTy
Copy link
Member

LukasTy commented Apr 8, 2025

Isn't this breaking? Seems odd that we are adding it now 🤔

I'd say that this is slightly breaking, since people will need to adjust their setup in case they were explicitly using the aliased modern bundle. 🤔
If we could squeeze this in before the X stable release, it would be awesome. 🤞 🙈

@Janpot
Copy link
Member Author

Janpot commented Apr 8, 2025

I'd say that this is slightly breaking, since people will need to adjust their setup in case they were explicitly using the aliased modern bundle.

Yes, but they already have to do that as part of v7. (and X v8 too btw)

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Janpot Janpot merged commit 18e065d into mui:master Apr 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code-infra] Deprecate the modern bundles Usage of 'mui-modern' custom bundle
6 participants