[Table] Fixing selectAll functionality a bit #4589
Conversation
| @@ -142,6 +142,14 @@ class Table extends Component { | |||
| allRowsSelected: this.props.allRowsSelected, | |||
| }; | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| if (typeof nextProps.allRowsSelected !== 'undefined' && this.props.allRowsSelected !== nextProps.allRowsSelected) { | |||
There was a problem hiding this comment.
Here we are allowing for the maintaining of allRowsSelected from outside of the component. This is necessary if utilizing "selected" on the data.
When maintaining the "selected" state outside of the table, you should expect to have to maintain the "all selected" state as well I believe.
|
Note that when |
muibot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
master
branch
from
53b828e to
ea2538e
Compare
|
The |
This PR is for improvements made to the Table component's functionality. There are quite a few issues that basically render the component unusable if you were to want to use the
selectableproperty. Although this PR does not fix every issue out there, it does appear to fix #1345, as well as improves handling of selecting/unselecting rows.For example, when using select all, it would not uncheck all rows after unselecting the check all box (when 'deselect on clickaway' is disabled).
Another example is when using select all and you have all the boxes checked and then click on one, it will change to only have that single one selected. Currently, when you have rows that were preselected (like the complex example), it incorrectly leaves the wrong one checked (if you try checking one of the preselected rows).
Basically, my goal is to get this component to a point where we can use it in our project. The way it stands right now with how the
select allfunctionality works, we'd have to do some hacking to get it working. This PR should fix the major issues with that functionality.Closes #1345