Skip to content

[core] Remove redundant overrides resolver #45970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 29, 2025
Merged

[core] Remove redundant overrides resolver #45970

merged 7 commits into from
Apr 29, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Apr 20, 2025 •
edited by oliviertassinari
Loading

These overrides resolvers are redundant.

See mui/mui-x#17466

@romgrk romgrk added core Infrastructure work going on behind the scenes enhancement This is not a bug, nor a new feature labels Apr 20, 2025
@romgrk romgrk requested a review from a team April 20, 2025 10:24
@mui-bot
Copy link

mui-bot commented Apr 20, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45970--material-ui.netlify.app/

@mui/material: parsed: -0.61% 😍, gzip: -0.31% 😍
@mui/material/TablePagination: parsed: -0.35% 😍, gzip: -0.13% 😍
@mui/material/Autocomplete: parsed: -0.28% 😍, gzip: -0.11% 😍
@mui/material/TextField: parsed: -0.25% 😍, gzip: -0.13% 😍
@mui/lab: parsed: -0.21% 😍, gzip: -0.08% 😍
@mui/material/Select: parsed: -0.22% 😍, gzip: -0.10% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 3ad821e

siriwatknp
siriwatknp approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please fix the CI before merging

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 21, 2025 •
edited
Loading

So we save bundle size because of?

material-ui/packages/mui-system/src/createStyled/createStyled.js

Lines 118 to 120 in e3d807e

// TODO v6: remove `lowercaseFirstLetter()` in the next major release
// For more details: https://github.com/mui/material-ui/pull/37908
overridesResolver = defaultOverridesResolver(lowercaseFirstLetter(componentSlot)),

@oliviertassinari oliviertassinari changed the title [core] refactor: remove redundant overrides resolver [core] Remove redundant overrides resolver Apr 21, 2025
@romgrk
Copy link
Contributor Author

romgrk commented Apr 22, 2025 •
edited
Loading

I'm mainly doing this to make our codebase less verbose and because I love deleting code.

@romgrk romgrk merged commit b68fe64 into mui:master Apr 29, 2025
24 checks passed
@romgrk romgrk deleted the refactor-rm-overrides-resolver branch April 29, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes enhancement This is not a bug, nor a new feature performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romgrk @mui-bot @oliviertassinari @siriwatknp