-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[docs][chat] Add suggestions to edit with MUI Chat #46309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46309--material-ui.netlify.app/ Bundle size report@mui/material parsed: 0B(0.00%) gzip: 0B(0.00%) DetailsShow details for 100 more bundles (86 more not shown)@mui/lab/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%) |
|
|
||
| const handleClick = async () => { | ||
| if (!baseUrl) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should render nothing in that case. Otherwise you risk to render a button that does nothing
| const handleClick = async () => { | |
| if (!baseUrl) { | |
| return; | |
| } | |
| if (!baseUrl) { | |
| return null; | |
| } | |
| const handleClick = async () => { |
| } catch (err: any) { | ||
| setError(err as Error); | ||
| } finally { | ||
| clearTimeout(setLoadingTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why there is a setLoadingTimeout. After 200ms the loading interface will disappear even if the API call is still pending
…al-ui into docs/ai-suggestions
|
Less obstructive on mobile screens: Screen.Recording.2025-06-15.at.3.53.03.PM.mov |
alexfauquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fr me.
Don't forget to remove the aiSuggestion if it was only for demonstration purpose
|

aiSuggestionprop to the demo to render this UIinitialMessagefrom the/openAPI