-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[code-infra] Revert nx update #46538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46538--material-ui.netlify.app/ Bundle size report
|
| "groupName": "nx", | ||
| "description": "FIXME: Seems to cause never-ending windows builds in CI (e.g. https://github.com/mui/material-ui/actions/runs/16268045027/job/45928292854)", | ||
| "matchPackageNames": ["nx"], | ||
| "allowedVersions": "<= 20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to also add in mui-public so that we can control all repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen this only fail in this repo only so far though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the nx group itself. Not with the restricted version part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The group is just one package here. It's only there to control the version.
Try reverting #46529 to fix windows builds