[code-infra] Remove package.json module field
#46620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Netlify deploy previewBundle size report
|
Janpot
commented
Jul 29, 2025
| const newPackageData = { | ||
| ...packageDataOther, | ||
| private: false, | ||
| ...(packageDataOther.main ? { main: './index.js' } : {}), |
Member
Author
There was a problem hiding this comment.
@brijeshb42 this is the line to port to the build tool PR (module property removed).
Janpot
changed the title
module field
brijeshb42
approved these changes
Jul 29, 2025
zannager
changed the title
module fieldmodule field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix codesandbox and parcel without
packageExportsenabled. The issue is caused by top-level imprts having a cjs and esm variant through main/module fields but the subpath exports only having a cjs export through file system resolution. We can simply remove the module field to have both resolve to the cjs variant. this only applies on runtimes where the exports field is not supported (codesandbox, parcel, webpack@<=4,...).docs