[code-infra] Remove useless test step #46679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
test
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46679--material-ui.netlify.app/ Bundle size report
|
Member
|
History #24188 |
Member
Author
|
Ok, so that hasn't been doing anything then at least since #37853, where the |
michaldudak
approved these changes
Aug 11, 2025
brijeshb42
approved these changes
Aug 11, 2025
oliviertassinari
changed the title
| git add -f packages/mui-material/build || echo '/material declarations do not exist' | ||
| git add -f packages/mui-lab/build || echo '/lab declarations do not exist' | ||
| git add -f packages/mui-utils/build || echo '/utils declarations do not exist' | ||
| pnpm -r build:stable && pnpm -r build:types |
Member
There was a problem hiding this comment.
pnpm -r build:stable && pnpm -r build:typesShouldn't we keep this step? Otherwise, I don't see how:
node scripts/testBuiltTypes.mjscan work.
Member
Author
There was a problem hiding this comment.
Fixing in #46735
The test is testing whether our path aliasing causing imports outside of the package folder during our declaration generation. Better would be to just remove path aliasing altogether from declaration generation and fix all the inconsistencies in our setup. I did that as part of #46500. Will extract these changes on their own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure at some point this was testing something useful, but currently, this is testing exactly nothing. Those build folders are always empty at the start of this step and they are gitignored. The whole step is a no-op and has been for a long time.
This will save roughly 1m40s from the runtime