[code-infra] Remove fs-extra from netlify-plugin-cache-docs
#46740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const { nextjsCacheDir } = generateAbsolutePaths({ constants }); | ||
|
|
||
| const cacheDirExists = fse.existsSync(nextjsCacheDir); | ||
| const cacheDirExists = fs.existsSync(nextjsCacheDir); |
Member
Author
There was a problem hiding this comment.
@Janpot I know what you're going to say about this 😛 I'll fix it in a follow-up. Don't want to change too much in a single PR so it's easier to revert in case of issues
Netlify deploy previewhttps://deploy-preview-46740--material-ui.netlify.app/ Bundle size report
|
| const files = await utils.cache.list(); | ||
| await fse.mkdirp(PUBLISH_DIR); | ||
| await fse.writeJSON(cacheManifestPath, files, { spaces: 2 }); | ||
| await fs.promises.mkdir(PUBLISH_DIR, { recursive: true }); |
Member
Author
There was a problem hiding this comment.
Only using fs.promises while we depend on sync methods. Once we get rid of existsSync, I'll update the import to be fs/promises and we can refactor this.
bernardobelchior
added
type: enhancement
Janpot
approved these changes
Aug 13, 2025
zannager
changed the title
fs-extra from netlify-plugin-cache-docsfs-extra from netlify-plugin-cache-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mui/mui-public#481.
Should allow removing
fs-extrafrom MUI X's repo, which failed due to this dependency (revert PR).The actual fix would be to move
fs-extrato the dependencies of the monorepo, but if we can get rid of better it would be better.The run was successful