[code-infra] Remove some csbci references #46797
Conversation
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46797--material-ui.netlify.app/ Bundle size report
|
Already reflected in all HEAD and all rulesets.
| "@mui/styled-engine": "^5.0.0-alpha.16", | ||
| - "@mui/material": "^5.0.0-alpha.15", | ||
| + "@mui/material": "https://pkg.csb.dev/mui/material-ui/commit/371c952b/@mui/material", | ||
| + "@mui/material": "https://pkg.pr.new/mui/material-ui/@mui/material@b0f26aa", |
There was a problem hiding this comment.
I'm going a bit off topic.
What's the rationale for not using --compact option? Vite uses it, Rolldown too, but with our npm package maze, showing the path to the source might be simpler.
I was also thinking of removing the option to change the default https://github.com/mui/mui-public/blob/cf68446433d3e1fcb7a2be55e7fdf866835c36b6/.github/workflows/ci-base.yml#L10. I fail to envision a use case to allow one repository to do it differently from the standard.
There was a problem hiding this comment.
What's the rationale for not using
--compactoption?
There's not really a "rationale" behind it. It's just not very important to have compact urls. One drawback of it is that packages must have been published at least once, so our current method of listing all public packages would break if someone introduces a new package. We could get around this by expanding our list-workspaces command with a --published-only flag. But it will slow down this command ofcourse. Asking copilot to look into this. I'm also opening mui/mui-public#605.
Personally I don't care that much about the length of those urls, I will always copy them from somewhere anyway. I think long urls are acceptable if as a trade-off we can now preview newly introduced packages without having to publish them yet. But others may make a different trade-off.
Ideally, csbci just removes this flag and automatically provides the compact url if a package is published. I opened stackblitz-labs/pkg.pr.new#402
There was a problem hiding this comment.
It's just not very important to have compact urls. One drawback of it is that packages must have been published at least once, so our current method of listing all public packages would break if someone introduces a new package.
This makes sense; this would lean toward simply not supporting compact. What I wanted to push for is no options to configure it, so we have it everywhere the same way (unless there is a real reason to allow different things between different repositories, but it seems that there isn't).
3 participants
Remove some outdated references to our usage of codesandbox ci
Closes mui/mui-public#509