[internal] Refactor useForkRef TS types: tighten cleanupRef and simplify ref typing
#46967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46967--material-ui.netlify.app/ Bundle size report
|
wo-o29
changed the title
zannager
added
the
internal
DiegoAndai
requested review from
siriwatknp
and removed request for
DiegoAndai
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
useForkRef by tightening cleanupRef type and simplify ref typing
ZeeshanTamboli
changed the title
useForkRef by tightening cleanupRef type and simplify ref typinguseForkRef TS types by tightening cleanupRef type and simplify ref typing
ZeeshanTamboli
changed the title
useForkRef TS types by tightening cleanupRef type and simplify ref typinguseForkRef TS types: tighten cleanupRef and simplify ref typing
ZeeshanTamboli
approved these changes
Sep 27, 2025
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
useForkRefhook by refining the type ofcleanupRefto always be a function, removing unnecessary type assertions on refs, and narrowing theinstanceparameter type inrefEffectfromInstance | nulltoInstance. These changes increase type safety and code clarity:Changed
cleanupReftype fromvoid | (() => void)to() => voidbecause it always holds a cleanup function.Removed redundant
as React.RefObjecttype assertions for cleaner, clearer code.Narrowed
refEffect'sinstanceparameter type since null values are guarded before invocation.I have followed (at least) the PR section of the contributing guide.