Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Nov 5, 2025

@Janpot Janpot added the docs Improvements or additions to the documentation. label Nov 5, 2025
@mui-bot
Copy link

mui-bot commented Nov 5, 2025

Netlify deploy preview

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 172c7cb

@Janpot Janpot marked this pull request as ready for review November 5, 2025 17:00
@Janpot Janpot requested a review from a team November 5, 2025 17:11
Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for doing this? I'm thinking of a use case where we might be linking through a pretty url to a destination that could change, ie, base-ui.com/r/discord to the actual discord url.

@Janpot
Copy link
Member Author

Janpot commented Nov 5, 2025

Any specific reason for doing this?

Avoid unnecessary hops when clicking a link. a 301 means the content has "moved permanently", meaning "update your links"

I'm thinking of a use case where we might be linking through a pretty url to a destination that could change, ie, base-ui.com/r/discord to the actual discord url.

I suppose this should 302 redirect, and we shouldn't resolve those

@Janpot Janpot enabled auto-merge (squash) November 5, 2025 17:47
@Janpot Janpot requested a review from brijeshb42 November 7, 2025 11:29
@Janpot Janpot merged commit 0dc423f into mui:master Nov 7, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants