Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Layout] Allow the component to be an item & container #5827

Merged
merged 1 commit into from
Dec 28, 2016
Merged

[Layout] Allow the component to be an item & container #5827

merged 1 commit into from
Dec 28, 2016

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 26, 2016 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

As it turns out, allowing an <Layout /> to be an item and a container at the same time is useful.
For instance, you can control the vertical and horizontal gutter.

I have added a stress test to make sure we don't break it:

screenshot

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Dec 26, 2016
@oliviertassinari oliviertassinari added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Dec 26, 2016
@oliviertassinari oliviertassinari mentioned this pull request Dec 27, 2016
Closed
@oliviertassinari oliviertassinari merged commit 1450e2b into mui:next Dec 28, 2016
@oliviertassinari oliviertassinari deleted the layout-improve branch December 28, 2016 08:47
@oliviertassinari oliviertassinari mentioned this pull request Jan 30, 2017
Closed
@zannager zannager added the component: Container The React component label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: Container The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @muibot @zannager