[Tab] Allow overriding button style on tabs #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Dec 28, 2016
| @@ -27,6 +27,10 @@ class Tab extends Component { | |||
| static muiName = 'Tab'; | |||
|
|
|||
| static propTypes = { | |||
| /** | |||
| * Override the inline-styles of the button element | |||
There was a problem hiding this comment.
Missing dot at the end of the sentence.
| @@ -27,6 +27,10 @@ class Tab extends Component { | |||
| static muiName = 'Tab'; | |||
|
|
|||
| static propTypes = { | |||
| /** | |||
oliviertassinari
added
component: tabs
|
Updated to address comments |
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to set a different height than 72px for tabs.