Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableBody] Fix row selection re-render #5905

Merged
merged 1 commit into from
Jan 11, 2017
Merged

[TableBody] Fix row selection re-render #5905

merged 1 commit into from
Jan 11, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 10, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This is a continuation of #5884.
Thanks @dchambers for submitting the original PR.

Closes #5884.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jan 10, 2017
@oliviertassinari oliviertassinari merged commit 5fa1463 into mui:master Jan 11, 2017
@oliviertassinari oliviertassinari deleted the table-fix-unselect-logic branch January 11, 2017 07:44
@dchambers
Copy link

Thanks @oliviertassinari 👍

@Serfenia
Copy link

Serfenia commented Feb 9, 2017

@oliviertassinari This requires you to always pass allRowsSelected. If I don't use that property and still programmatically set my rows, then regards any props updates the rows stay selected due to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants