Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Layout] Warn about wrong usage of the item & container combination #6040

Merged
merged 1 commit into from
Jan 31, 2017
Merged

[Layout] Warn about wrong usage of the item & container combination #6040

merged 1 commit into from
Jan 31, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 30, 2017 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I couldn't find a way to test that without stubbing the console so I didn't.

I'm using a wrapper component as providing the warning at the propTypes level allow to have the component stack. Also, I have to handle react-docgen constraints.

Closes #6013.

@oliviertassinari oliviertassinari added component: Grid The React component. next labels Jan 30, 2017
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 30, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jan 30, 2017
@mbrookes mbrookes changed the title [Layout] Warn about wrong usage of the item&container combinaison [Layout] Warn about wrong usage of the item & container combination Jan 30, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 31, 2017
@oliviertassinari oliviertassinari merged commit e8a5f43 into mui:next Jan 31, 2017
@oliviertassinari oliviertassinari deleted the layout-warn-wrong-usage branch January 31, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: Grid The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Layout] align and justify have no affect on item
2 participants
@oliviertassinari @muibot