[core] Add missing babel-runtime dependency #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Apr 7, 2017
oliviertassinari
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
oliviertassinari
commented
Apr 7, 2017
src/Menu/MenuList.js
Outdated
| @@ -93,7 +97,7 @@ export default class MenuList extends Component { | |||
|
|
|||
| handleItemFocus = (event) => { | |||
| const list = findDOMNode(this.list); | |||
| if (list) { | |||
| if (list instanceof HTMLElement) { | |||
There was a problem hiding this comment.
Suggested by facebook/flow#3548 (comment)
oliviertassinari
commented
Apr 7, 2017
src/Menu/MenuList.js
Outdated
| @@ -110,15 +114,22 @@ export default class MenuList extends Component { | |||
| return; | |||
| } | |||
|
|
|||
| if (currentTabIndex && currentTabIndex >= 0) { | |||
| if (currentTabIndex && currentTabIndex >= 0 && | |||
| // $FlowFixMe | |||
There was a problem hiding this comment.
muibot
added
the
PR: needs revision
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
muibot
added
the
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
mbrookes
reviewed
Apr 7, 2017
| @@ -85,15 +85,20 @@ export default class Menu extends Component { | |||
| const list = ReactDOM.findDOMNode(this.menuList); | |||
|
|
|||
| if (this.menuList && this.menuList.selectedItem) { | |||
| // $FlowFixMe | |||
There was a problem hiding this comment.
What are all these comments for?
There was a problem hiding this comment.
For flow issues I don't have time to fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.