[utils] Remove throttle #6545
Merged
[utils] Remove throttle #6545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agamrafaeli
commented
Apr 8, 2017
•
agamrafaeli
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
The only usage of throttle was moved to use lodash's implementation
muibot
added
PR: Needs Review
PR: needs revision
|
Codecov fails because I removed tests for code that doesn't exist anymore. ;) |
3 tasks
| import { | ||
| transform, | ||
| contains, | ||
| find, | ||
| throttle, | ||
| } from './helpers'; | ||
|
|
||
| describe('utils//helpers.js', () => { |
There was a problem hiding this comment.
We don't use it anymore!
oliviertassinari
approved these changes
Apr 8, 2017
oliviertassinari
added
next
and removed
PR: needs revision
muibot
added
the
PR: needs revision
|
@oliviertassinari this may be nitpicking, but as the changes were merged, can you mark your requested changes as done? |
oliviertassinari
removed
the
PR: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.