[ButtonBase] Change tests to use faketimers #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing of keyboard focus on button base relied on a certain time gap. This commit changes the test for this case to use sinon's fake timers
oliviertassinari
requested changes
Apr 9, 2017
src/internal/ButtonBase.spec.js
Outdated
| done(); | ||
| }, 200); | ||
| after(() => { | ||
| clock.restore(); |
There was a problem hiding this comment.
I would rather have the after block at the top, right under the before bloc. It's our convention. Plus the setup and teardown phases are deeply linked.
oliviertassinari
added
next
test
PR: needs revision
|
@oliviertassinari made the relevant changes |
oliviertassinari
approved these changes
Apr 10, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
|
@agamrafaeli Thanks 😄 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing of keyboard focus on button base relied on a certain time gap.
This commit changes the test for this case to use sinon's fake timers