[TextField] Fix TextField with Chinese input method #6562
Conversation
Use compositionstart event to prevent not selected words trigger event.
| case 'compositionend': this.setState({isTyping: false}); break; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
You also need to pass the event though to the appropriate composition prop if set. There are a couple of patterns for that, in use, either test if the prop is defined or (my preference) give the props empty arrow function defaults: () = {}.
mbrookes
added
PR: needs revision
| @@ -191,6 +191,9 @@ class TextField extends Component { | |||
| * @param {string} newValue The new value of the text field. | |||
| */ | |||
| onChange: PropTypes.func, | |||
| onCompositionEnd: PropTypes.func, | |||
| onCompositionStart: PropTypes.func, | |||
| onCompositionUpdate: PropTypes.func, | |||
mbrookes
changed the title
|
facebook/react#3926 I found the same React issue before I realised you'd already linked to it! 😄 Reading that, we'll need to test carefully that this fixes the issue across browsers. It seems the event order is not consistent. |
| @@ -356,6 +361,14 @@ class TextField extends Component { | |||
| } | |||
| }; | |||
|
|
|||
| handleComposition = (event) => { | |||
There was a problem hiding this comment.
Please could you add a TODO comment explaining why this is needed (reference the FB issue), so we can revisit and remove the workaround if / when Facebook finally fix it (there is a PR pending review since Dec 2016).
|
After upgrade to v0.17.2 found this issue resolved by #6456 |
Use compositionstart event to prevent not selected words trigger event.
Closes #6527.
ref facebook/react#3926