[docs] Fix build:docs command #6606
Conversation
oliviertassinari
commented
Apr 14, 2017
•
oliviertassinari
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
| @@ -377,4 +377,3 @@ class Tabs extends Component { | |||
| } | |||
|
|
|||
| export default withWidth()(Tabs); | |||
| export { Tabs as PureTabs }; // for testing purposes | |||
There was a problem hiding this comment.
@shawnmcknight Here we are.
There was a problem hiding this comment.
@oliviertassinari Got it - thanks! I was trying to dive() against the rendered <Tabs> but failing because it returned a function. I see why your way is working and mine wasn't. I appreciate the insight! 👏
There was a problem hiding this comment.
On second look, it appears (although you did it far cleaner than in my attempts) that I was actually using dive() correctly. It's your changes to withWidth that allowed this to work. Either way, glad to have learned something today 😀
| | centered | bool | false | If `true`, the tabs will be centered. This property is intended for large views. | | ||
| | children | node | | The content of the component. | | ||
| | className | string | | The CSS class name of the root element. | | ||
| | fullWidth | bool | false | If `true`, the tabs will grow to use all the available space. This property is intended for small views. | | ||
| | index | number | | The index of the currently selected `Tab`. | | ||
| | index | number | | The index of the currently selected `BottomNavigation`. | |
There was a problem hiding this comment.
@oliviertassinari Out of curiosity, why was this line changed back to the original form? I had assumed the usage of BottomNavigation instead of Tab was an oversight, but maybe I am mistaken.
There was a problem hiding this comment.
Ahh, in looking further, I missed updating the same doc in Tabs.js. Now I see that the docs generator is rebuilding the docs from the components. Silly me, I created the docs by hand 😧 .
I'll get a PR in for fixing Tabs.js and rebuilding the docs.
There was a problem hiding this comment.
I can fix that here, thanks for raising it.
oliviertassinari
force-pushed
the
next-build-docs
branch
from
aa3c39e to
db38582
Compare
muibot
added
PR: needs revision
