Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add a supported browsers section #7174

Merged
merged 2 commits into from
Jun 19, 2017
Merged

[docs] Add a supported browsers section #7174

merged 2 commits into from
Jun 19, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 18, 2017 •
edited
Loading

Closes #1865

capture d ecran 2017-06-19 a 01 27 15

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v1.x.x test labels Jun 18, 2017
oliviertassinari
oliviertassinari commented Jun 18, 2017
View reviewed changes
test/karma.conf.js
// browser: 'edge',
// browser_version: 'latest',
// },
BrowserStack_Edge: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wasn't a piece of cake to make the tests run!

mbrookes
mbrookes reviewed Jun 19, 2017
View reviewed changes
docs/src/pages/getting-started/supported-browsers.md Outdated
# Supported Browsers

Material-UI supports the latest, stable releases of all major browsers and platforms.
On Windows, we support Internet Explorer 11 & Microsoft Edge.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it sound like those are the only browsers supported on Windows, but I can't think of a better way to phrase it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove On Windows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change that with specific versions over "latest" 👍 .

@oliviertassinari oliviertassinari merged commit 169f1b3 into mui:next Jun 19, 2017
@oliviertassinari oliviertassinari deleted the browser-support branch June 19, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stunaz stunaz stunaz left review comments

@mbrookes mbrookes mbrookes left review comments

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Document target browser compatibility
4 participants
@oliviertassinari @rosskevin @mbrookes @stunaz