[Icons] Modernize icons package #7203
Conversation
| "build:babel": "babel --presets es2015,react -d ./build ./src", | ||
| "build:babel:es2015module": "BABEL_ENV=modules babel ./src/index.js --presets=../../../scripts/material-ui-babel-preset-es2015 --out-file ./build/index.es.js", |
There was a problem hiding this comment.
Some naive question as I haven't tried.
Would copy pasting the build commands for the main package work?
https://github.com/callemall/material-ui/blob/next/package.json#L26-L27
There was a problem hiding this comment.
Yes, it is possible. But it could be a complication. In the root .babelrc file there are many plugins that seem redundant. So, if we will choose this option, it will require to list all of the babel plugins in the 'material-ui-icons' package development dependencies.
As an alternative, it is possible to clean up changes in my PR to match the 'material-ui' package scripts.
There was a problem hiding this comment.
Why would we need to list all of the babel plugins in the 'material-ui-icons' package development dependencies? People need to install the root dependencies beforehand.
I would rather have things as symetric as possible.
There was a problem hiding this comment.
Ok. I understand your point. I will prepare additional changes.
|
@kvet Thank you |
This PR fixes the following problems:
index.jsfile of thematerial-ui-iconspackage did not work. Icons were reexported as named exports but defined as default export.