Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Fix warning when using onRequestDelete #7407

Merged
merged 1 commit into from
Jul 11, 2017
Merged

[Chip] Fix warning when using onRequestDelete #7407

merged 1 commit into from
Jul 11, 2017

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Jul 11, 2017 •
edited
Loading

This removes the prepareStyles call for the style of a Chip's delete icon. The SvgIcon already calls prepareStyle itself, resulting in a warning.
It's a regression introduced in v0.18.6 by #7320

This fixes #7394 and is related to TeamWertarbyte/material-ui-chip-input#123 and redux-form/redux-form#3164

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@leMaik leMaik changed the title [Chip] Don't prepare the delete icon style [Chip] Fix warning with delete button Jul 11, 2017
@leMaik leMaik changed the title [Chip] Fix warning with delete button [Chip] Fix warning when using onRequestDelete Jul 11, 2017
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module! labels Jul 11, 2017
@oliviertassinari oliviertassinari merged commit 09e1462 into mui:master Jul 11, 2017
@oliviertassinari
Copy link
Member

@leMaik Thanks

@leMaik leMaik deleted the fix-chip-icon-style branch July 11, 2017 22:22
@oliviertassinari oliviertassinari mentioned this pull request Jul 12, 2017
Closed
djbuckley added a commit to manchesergit/material-ui that referenced this pull request Jul 18, 2017
@djbuckley
Merge remote-tracking branch 'call_em_all_-_master/master'
f593d4f 
* call_em_all_-_master/master:
  [ROADMAP] Update the release plan for v1: fasteeer (mui#7428)
  fix(package): update recompose to version 0.24.0 (mui#7415)
  [Chip] Don't prepare the delete icon style (mui#7407)

# Conflicts:
#	package.json

upstream merge for (#125)
@BrandKNY BrandKNY mentioned this pull request Jul 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leMaik @oliviertassinari